Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update asdf repo if it exists #539

Merged
merged 21 commits into from
Mar 17, 2023
Merged

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Mar 16, 2023

This rebases #394 & updates the test cases

Update the asdf repo if it is already cloned to the system.

Closes #394
Closes #356

@jthegedus
Copy link
Contributor Author

jthegedus commented Mar 17, 2023

As commented in the code, it is not clear how hosted runners get to this point in the code as the only validation is to check for ~/.asdf/bin/asdf which one assumes exists.

Since we have no self-hosted runners to test this issue ourselves, we will trust in the OP of #394 and assume this fix is correct.

@jthegedus jthegedus merged commit 4907cdf into master Mar 17, 2023
@jthegedus jthegedus deleted the WillBooster-update-existing branch March 17, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install action fails if asdf is already installed
2 participants